DataFlex Open Source Projects: Issueshttps://projects.vdf-guidance.com/https://projects.vdf-guidance.com/favicon.ico2023-01-11T10:39:30ZDataFlex Open Source Projects
Redmine DfRefactor - Feature #191 (New): Unused local variables & commented codehttps://projects.vdf-guidance.com/issues/1912023-01-11T10:39:30ZWil van Antwerpen
<pre><code class="text syntaxhl"><span class="CodeRay">
Procedure DoAsk
Integer iResponse
// Move (YesNo_Box("I ask if...", "", MB_DEFBUTTON2)) to iResponse
// If (iResponse = "MBR_YES") Begin
If (YesNo_Box("I ask if...", "", MB_DEFBUTTON2) = "MBR_YES") Begin
End
End_Procedure
</span></code></pre>
<p>In this case "iResponse" gets deleted. In case you uncomment the code you are going to get compiler errors.</p>
<p>One can say... comment the variable instead of delete it!<br>
Maybe in this example it is easy, but in situations like "Integer iResponse1 iResponse2" it gets complicated.</p>
<p>I think it is fine as it is now, but I also think it was worth telling about.</p>
<p>From:<br>
<a href="https://support.dataaccess.com/Forums/showthread.php?69408-DFRefactor-3-2-1-0-Unused-local-variables-amp-commented-code">https://support.dataaccess.com/Forums/showthread.php?69408-DFRefactor-3-2-1-0-Unused-local-variables-amp-commented-code</a></p>
DfRefactor - Feature #190 (New): Unused variables to also delete blank line https://projects.vdf-guidance.com/issues/1902023-01-11T10:36:19ZWil van Antwerpen
<p>Suppose this fragment of code...</p>
<pre><code class="text syntaxhl"><span class="CodeRay">
Procedure SayHello
String sVariable
Send Info_Box "Hello!"
End_Procedure
</span></code></pre>
<p>It gets changed to...</p>
<pre><code class="text syntaxhl"><span class="CodeRay">
Procedure SayHello
Send Info_Box "Hello!"
End_Procedure
</span></code></pre>
<p>Would it be great that all blank lines gets deleted?<br>
I know it is something personal of each one. In my case I write variables, blank line, more code.</p>
<p>Maybe a new refactoring tool can be developed, one that deletes blank lines just after "Procedure" (and similar) and just before "End_Procedure" (and similar).<br>
And if we accept this, then the tool can add a blank line just after variables declaration, before and after "Forward Send (and similar), before "Function_Return" (and similar).</p>
<p>See:<br>
<a href="https://support.dataaccess.com/Forums/showthread.php?69407-DFRefactor-3-2-1-0-Unused-local-variables-also-delete-line">https://support.dataaccess.com/Forums/showthread.php?69407-DFRefactor-3-2-1-0-Unused-local-variables-also-delete-line</a></p>
DfRefactor - Bug #189 (New): Refactor Calc/MoveInt does not save changeshttps://projects.vdf-guidance.com/issues/1892022-08-12T10:46:23ZWil van Antwerpen
<p>I have run, only, "Calc/MoveInt" function and this is the report.</p>
<pre><code class="text syntaxhl"><span class="CodeRay">Created by: Automated Source Code Refactoring for DataFlex -- 12/08/2022 11:55:00,097
Total number of files changed: 0 out of 1116 Files.
Statistics:
===========
Replaced to use 'Move' command 170
Process completed. Elapsed Time: 00:03:16.38
</span></code></pre>
<p>So, it replaces 170 occurrences but not file is being modified. I have verified it with the help of the version control system.</p>
<p>See also:<br>
<a href="https://support.dataaccess.com/Forums/showthread.php?68878-DFRefactor-Calc-MoveInt">https://support.dataaccess.com/Forums/showthread.php?68878-DFRefactor-Calc-MoveInt</a></p>
DfRefactor - Bug #188 (New): Keyword casing does not match DAWs case on some wordshttps://projects.vdf-guidance.com/issues/1882022-08-12T10:37:54ZWil van Antwerpen
<p>For example on "for" and "to"</p>
<p>see also:<br>
<a href="https://support.dataaccess.com/Forums/showthread.php?68862-DFRefactor-Upper-Lowercase&goto=newpost">https://support.dataaccess.com/Forums/showthread.php?68862-DFRefactor-Upper-Lowercase&goto=newpost</a></p>
DfRefactor - Bug #187 (New): drop self has issues with multiple objects on the same linehttps://projects.vdf-guidance.com/issues/1872022-08-10T16:49:36ZWil van Antwerpen
<p>Jose reports the following:</p>
<pre><code class="text syntaxhl"><span class="CodeRay"> "Send Method of oObject (oObject(Self))" got changed to "Send Method of oObject oObject)"
"Get Function of oObject (Current_Record(oDD(Self))) (Value(Form1(Group1(Self)), 0)) to nVariable" got changed to "Get Function of oObject Current_Record(oDD)) (Value(Form1(Group1(Self)), 0)) to nVariable"
Send Method to (oObject(Self)) (oObject(Self)). It changes the first Self, but not the second.
"If table.field ne "" Set Value of (Form1(Self)) Item 0 to table.field" got changed to "If table.field ne "" Set Value of Form1) Item 0 to table.field" (Yes, two spaces between "of" and "Form1")
Not a DFRefactor problem: "Get Field_Current_Value of (oDD(Self))Field table.field to sVariable" (it worked) got chagend to "Get Field_Current_Value of oDDField table.field to sVariable" (don't compile)
It doesn't parse commented lines
Send method of (oObject1(oObjectN(Self))). It doesn't detect this. Not a problem, in this case the solution is not only quit (Self).
"Send Method (Value(oObjeto(Self)))" got changed to "Send method Value(oObject)"
</span></code></pre>
<p>see also: <a href="https://support.dataaccess.com/Forums/showthread.php?68858-DFRefactor-Drop-(Self)">https://support.dataaccess.com/Forums/showthread.php?68858-DFRefactor-Drop-(Self)</a></p>
cFileSystem Library - Suggestion #186 (New): inconsistency regarding pbEOF propertyhttps://projects.vdf-guidance.com/issues/1862021-06-01T07:15:05ZWil van Antwerpen
<p>inside package there is a note to not use pbEOF property anymore.. and use BinerayEndOfFile function instead.</p>
<p>But, There are some functions that still sets pbEOF, instead of setting the private structured member value for the file-handle array.</p>
<p>BinaryFileReadUChar</p>
<pre>
If (iBytesRead = 0 or iBytesRead <> iNumberOfBytes) Begin
Set pbEOF to True
</pre>
<p>Shouldn't it be setting the bEndOfFile member from the array plsFile property ?</p>
<pre>Struct structFile
Handle hFilehandle
String sFilename // Assigned filename in OEM format.
Boolean bEndOfFile // True then the end of the binary file had been read.
End_Struct
</pre>
<p>See also:<br>
<a href="https://support.dataaccess.com/Forums/showthread.php?64903-cFileSystem-Lib&p=365377#post365377">https://support.dataaccess.com/Forums/showthread.php?64903-cFileSystem-Lib&p=365377#post365377</a></p>
DfRefactor - Suggestion #185 (New): Comments at column 0 should not be indentedhttps://projects.vdf-guidance.com/issues/1852021-01-16T23:29:24ZWil van Antwerpen
<p>Reported by Marco:</p>
<p>Indenting of ‘root comments’<br>
I think that root comments should never be indented, as these are normally for (temporary) commented out code</p>
<p>See attachment:</p>
<p>Please ignore the three lines in the middle, these should obviously be indented.</p>
DfRefactor - Bug #184 (New): Don't change casing for struct membershttps://projects.vdf-guidance.com/issues/1842021-01-16T23:26:24ZWil van Antwerpen
<p>Reported by Marco.</p>
<p>Struct members should not change case ever.<br>
Btw, this is classified as a bug and not as a suggestion because it can break programs if you have structs that you depend on for JSON.</p>
<p>see attachment.</p>
DfRefactor - Suggestion #183 (New): Indenting of use Statements to respect scopehttps://projects.vdf-guidance.com/issues/1832021-01-16T23:23:12ZWil van Antwerpen
<p>Reported by Marco</p>
<p>Currently Use statements are by default always moved to column 0.<br>
There are times when this might not be preferred.</p>
<p>See attachment.</p>
<p>We could probably look at the scope and line out by scope (not sure if this should be configurable, I prefer not, but perhaps yes)</p>
DfRefactor - Bug #181 (New): Space in filename confuses parserhttps://projects.vdf-guidance.com/issues/1812020-11-10T14:37:10ZWil van Antwerpen
<p>On behalf of Michael Mullan via discord channel</p>
<p>Use "PrintPackingLists3 Test.rv"<br>
confuses the parser, it didn't recognize the filename with the space in it, and it move the file to a backup folder.</p>
SyncFusion Library - Bug #180 (New): Commenting out a column when using remember column logic bre...https://projects.vdf-guidance.com/issues/1802020-10-22T17:20:27ZWil van Antwerpen
<p>If you comment out a column for testing then the view can show up blank afterwards.<br>
This happens in our Swedish demo view if you comment out any column after using the remind column order logic.</p>
<p>You'll have to press the "reset Layout" button to fix that and clear the data for the remember logic.</p>
<p>This could be handled with more grace as simply showing an empty page.</p>
SyncFusion Library - Bug #179 (New): Pdf export has some issues with date columnshttps://projects.vdf-guidance.com/issues/1792020-10-22T17:17:50ZWil van Antwerpen
<p>If you have a date column in your data then sometimes the Pdf export does not work.<br>
For example this is the case now in our Swedish demo view.</p>
SyncFusion Library - Bug #178 (New): Numeric data needs to be filled?https://projects.vdf-guidance.com/issues/1782020-10-16T13:07:45ZWil van Antwerpen
<p>Reported on behalf of Albin:</p>
<p>We found something a little weird. <br>
We noticed that you don´t have to fill all columns if you don´t want to. We think this is a good thing. <br>
Because very often we need to have a lot of columns in a grid but all users/customers do not wish to see them. So we hide a couple of columns to most users. Very often we also use esql to collect the data and then we don´t collect data for those columns that is not visible (need to keep the system fast). </p>
<p>Now, this works with this class most of the times, but if we have numeric columns that we fill with “jsonTypeDouble” then the grid comes out blank. We can see all the data being transferred to the grid but if a “jsonTypeDouble” column exist and we don´t provide data to one of those columns, the grid shows no rows at all. </p>
<p>Not a huge deal because we can autofill these columns with a 0 but I thought I should share it because I just spent 3 hours trying to figure out what was happening to my grid that was working just fine yesterday and now gave me no data. </p>
SyncFusion Library - Bug #177 (New): Reordered columns don't always come back on reopening viewhttps://projects.vdf-guidance.com/issues/1772020-10-16T13:06:06ZWil van Antwerpen
<p>When you reorder the columns in a webview and save/restore those columns like in the SyncFusionOrderSwedish.wo demo view the reordered columns do not always get restored in the correct order.</p>
<p>That is the order that the view tries to restore is correct, but the list displays it in the normal order.<br>
This can be seen when going to the dashboard and back to this view.</p>
<p>If you instead go to another view, the order <em>is</em> remembered.</p>
SyncFusion Library - Bug #176 (New): Export functionality does not work when groupedhttps://projects.vdf-guidance.com/issues/1762020-10-07T09:16:01ZWil van Antwerpen
<p>Albin reported to me that there's issues with the Pdf/Excel/Csv export when you the list has a group active.</p>
<p>The error is deep in the bowels of syncfusion and it isn't 100% sure at this moment why.</p>
<p>There's currently 2 workarounds.</p>
<p>The first one is easiest. <br>
Disable this functionality when a group is active.</p>
<p>The second one is a tad more involved and requires some changes to the javascript wrapper and does not work if you use any aggregates (see reply below)</p>